-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Demo): remove karma and jasmine #1545
Conversation
Codecov Report
@@ Coverage Diff @@
## release #1545 +/- ##
========================================
Coverage 98.72% 98.72%
========================================
Files 126 126
Lines 4313 4313
Branches 571 609 +38
========================================
Hits 4258 4258
Misses 55 55 Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## release #1545 +/- ##
========================================
Coverage 98.72% 98.72%
========================================
Files 126 126
Lines 4328 4328
Branches 610 610
========================================
Hits 4273 4273
Misses 55 55 Continue to review full report at Codecov.
|
package.json
Outdated
@@ -39,6 +39,8 @@ | |||
"test": "jest --watch", | |||
"test:ci": "jest --runInBand --coverage", | |||
"test:ci:local": "jest --coverage", | |||
"test:demo":"jest --config ./jest.demo.config.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assuming we can probably also remove lines 22/23 now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, and also move line 42 up under the Section: Demo App
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shani-terminus I hit the wrong button.. this was supposed to be a request for changes 🤦♂
97e5285
to
d26c8a4
Compare
to test demo, run \`yarn run test:demo\` ISSUES CLOSED: #1412
d26c8a4
to
62a2ae8
Compare
to test demo, run `yarn run test:demo`
ISSUES CLOSED: #1412