Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Demo): remove karma and jasmine #1545

Merged
merged 2 commits into from
Jun 13, 2019

Conversation

shani-terminus
Copy link
Contributor

to test demo, run `yarn run test:demo`

ISSUES CLOSED: #1412

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #1545 into release will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           release    #1545   +/-   ##
========================================
  Coverage    98.72%   98.72%           
========================================
  Files          126      126           
  Lines         4313     4313           
  Branches       571      609   +38     
========================================
  Hits          4258     4258           
  Misses          55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1ff50d...4311e17. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 6, 2019

Codecov Report

Merging #1545 into release will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           release    #1545   +/-   ##
========================================
  Coverage    98.72%   98.72%           
========================================
  Files          126      126           
  Lines         4328     4328           
  Branches       610      610           
========================================
  Hits          4273     4273           
  Misses          55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9700ddd...62a2ae8. Read the comment docs.

package.json Outdated
@@ -39,6 +39,8 @@
"test": "jest --watch",
"test:ci": "jest --runInBand --coverage",
"test:ci:local": "jest --coverage",
"test:demo":"jest --config ./jest.demo.config.js",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming we can probably also remove lines 22/23 now?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, and also move line 42 up under the Section: Demo App

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shani-terminus I hit the wrong button.. this was supposed to be a request for changes 🤦‍♂

@benjamincharity benjamincharity force-pushed the 1412-demo-remove-karma-jasmine branch from d26c8a4 to 62a2ae8 Compare June 13, 2019 19:08
@benjamincharity benjamincharity merged commit 3c0106c into release Jun 13, 2019
@benjamincharity benjamincharity deleted the 1412-demo-remove-karma-jasmine branch June 21, 2019 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove karma & jasmine from the Demo
2 participants