Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure all services are provided at the root level #2014

Closed
3 tasks done
benjamincharity opened this issue Feb 10, 2020 · 0 comments · Fixed by #2018
Closed
3 tasks done

Ensure all services are provided at the root level #2014

benjamincharity opened this issue Feb 10, 2020 · 0 comments · Fixed by #2018
Assignees
@benjamincharity
Labels
Focus: utility Helpers etc. Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects

Comments

@benjamincharity
Copy link
Contributor

benjamincharity commented Feb 10, 2020 •
edited
Loading

Example:

@Injectable({
  providedIn: 'root',
})
export class UserService {
}
  • Add providedIn definition to all external services
  • Verify AoT build works
  • Add note in any applicable docs that the service is providedIn root.
@benjamincharity benjamincharity added Focus: utility Helpers etc. Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects labels Feb 10, 2020
@benjamincharity benjamincharity self-assigned this Feb 12, 2020
benjamincharity added a commit that referenced this issue Feb 12, 2020
@benjamincharity
fix(Services): define external services as singletons
09790bf 
ISSUES CLOSED: #2014
@benjamincharity benjamincharity mentioned this issue Feb 12, 2020
Merged
benjamincharity added a commit that referenced this issue Feb 12, 2020
@benjamincharity
fix(Services): define external services as singletons
3c6fc4f 
ISSUES CLOSED: #2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamincharity benjamincharity

Labels
Focus: utility Helpers etc. Goal: Library Stabilization A task needed to get the library closer to it's final state Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Services): define external services as singletons GetTerminus/terminus-ui
1 participant
@benjamincharity