fix(Services): define external services as singletons #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ISSUES CLOSED: #2014
ghost
assigned 
github-actions
bot
added
PR: awaiting review
atlwendy
approved these changes
Feb 12, 2020
github-actions
bot
added
PR: approved
Codecov Report
@@ Coverage Diff @@
## release #2018 +/- ##
========================================
Coverage 98.94% 98.94%
========================================
Files 140 140
Lines 6428 6428
Branches 1080 1029 -51
========================================
Hits 6360 6360
Misses 68 68
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUES CLOSED: #2014
Note: Only two services from this library are used externally. I set both to root. I only added a note to the readme for the validators service as it's the only one the consumers really deal with.