Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paginator: Remove 'of X' from simple mode #2031

Closed
benjamincharity opened this issue Feb 18, 2020 · 0 comments · Fixed by #2033
Closed

Paginator: Remove 'of X' from simple mode #2031

benjamincharity opened this issue Feb 18, 2020 · 0 comments · Fixed by #2033
Assignees
@benjamincharity
Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects

Comments

@benjamincharity
Copy link
Contributor

In simple mode, the paginator won't know about the total # of pages so we need to hide this text
@benjamincharity benjamincharity added Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects labels Feb 18, 2020
@benjamincharity benjamincharity self-assigned this Feb 18, 2020
benjamincharity added a commit that referenced this issue Feb 18, 2020
@benjamincharity
fix(Paginator): simple mode no longer shows total count
0a58053 
ISSUES CLOSED: #2031
@benjamincharity benjamincharity mentioned this issue Feb 18, 2020
Merged
benjamincharity added a commit that referenced this issue Feb 18, 2020
@benjamincharity
fix(Paginator): simple mode no longer shows total count
d3e3cf6 
ISSUES CLOSED: #2031
benjamincharity added a commit that referenced this issue Feb 18, 2020
@benjamincharity
fix(Paginator): simple mode no longer shows total count
e8421d5 
ISSUES CLOSED: #2031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamincharity benjamincharity

Labels
Focus: component Issues concerning a specific component Target: latest Issues related to the latest version of the library (master) Type: bug An implemented item with undesired effects
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Paginator): simple mode no longer shows total count GetTerminus/terminus-ui
1 participant
@benjamincharity