Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Paginator): simple mode no longer shows total count #2033

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

benjamincharity
Copy link
Contributor

ISSUES CLOSED: #2031

Screen Shot 2020-02-18 at 10 01 30 AM

@benjamincharity benjamincharity requested a review from a team as a code owner February 18, 2020 15:45
@ghost ghost assigned benjamincharity Feb 18, 2020
@github-actions github-actions bot added PR: awaiting review PRs that need to be reviewed Size: S labels Feb 18, 2020
@benjamincharity benjamincharity force-pushed the 2031-paginator-simple-mode-fix branch from 0a58053 to d3e3cf6 Compare February 18, 2020 15:52
@codecov
Copy link

codecov bot commented Feb 18, 2020

Codecov Report

Merging #2033 into release will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           release    #2033   +/-   ##
========================================
  Coverage    98.94%   98.94%           
========================================
  Files          140      140           
  Lines         6438     6440    +2     
  Branches      1030     1031    +1     
========================================
+ Hits          6370     6372    +2     
  Misses          68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd1294...d3e3cf6. Read the comment docs.

@github-actions github-actions bot added PR: approved PRs that have passed the review process and removed PR: awaiting review PRs that need to be reviewed labels Feb 18, 2020
@benjamincharity benjamincharity merged commit e8421d5 into release Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: approved PRs that have passed the review process Size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paginator: Remove 'of X' from simple mode
2 participants