-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mmillet/spi 515 add all secrets option to ggshield secret scans #1024
Mmillet/spi 515 add all secrets option to ggshield secret scans #1024
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
+ Coverage 92.03% 92.05% +0.01%
==========================================
Files 181 181
Lines 7708 7726 +18
==========================================
+ Hits 7094 7112 +18
Misses 614 614
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6f89d8d
to
c6b96ce
Compare
1047a26
to
b6cb659
Compare
b6cb659
to
f9bb794
Compare
f9bb794
to
0e48da5
Compare
- remove `ignore_known_secrets=True`, which didn't make sense - add `all_secrets=True`, to get all secrets found by the backend Notes: - Since we add `all_secrets=True`, we also need to filter-out secrets [13:30:5 excluded by the backend - Since we changed the query params, all secret-related cassettes have been rewritten
0e48da5
to
9c8dba5
Compare
f63eef8
to
8f8252c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor remarks, but this looks good, and the addition of factories is great!
bb30607
to
8ae13a4
Compare
Fixes issues where test files are not the same depending on the OS
8ae13a4
to
cb39b68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
--all-secrets
option, such that ignore options are "ignored": all secrets are returned, withis_excluded
/exclude_reason
(sic) set appropriately in the policy breaks.What has been done
--all-secret
optionExclude reason
when appropriateValidation
Run ggshield scans on a file containing secrets with ignored / resolved issues, with and without
--all-secrets
optionPR check list
skip-changelog
label has been added to the PR.