-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: make ignore reason human readable in text output #1031
Conversation
948cf80
to
aa8b108
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1031 +/- ##
==========================================
+ Coverage 92.05% 92.09% +0.03%
==========================================
Files 181 181
Lines 7726 7752 +26
==========================================
+ Hits 7112 7139 +27
+ Misses 614 613 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c5c4888
to
0d74fc3
Compare
0d74fc3
to
5e23fe8
Compare
Introduces new models: - IgnoreReason - Secret, which is meant to extend the PolicyBreak model from pygitguardian
5e23fe8
to
075334c
Compare
ac0865c
to
9ba60b0
Compare
Also fixes some tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Love the stroke "small" word in the PR description 😅.
Thanks for this work. I think the code-base is less confusing thanks to these renamings.
Context
Following #1024 ,
smallfix to make ignore reasons human readable.Validation
Perform scans with ignored secrets (either from config or backend), with the
--all-secrets
options.Ensure the output contains ignore info (both for text and json output)
PR check list
skip-changelog
label has been added to the PR.Note: skipping changelog as it was included in previous MR.