Clean up reactions settings by rnystrom · Pull Request #2084 · GitHawkApp/GitHawk · GitHub

This repository was archived by the owner on Sep 20, 2023. It is now read-only.

Member

rnystrom commented Aug 11, 2018

From #2022 cc @Huddie

There were enough changes that it would've taken a while to update. Some things that I want to call out:

Explicit "disabled" value vs hacking "Disabled" into the unknown value
Localization for disabled
Code formatting! 4-space tabs, { on sameline (TODO SwiftLint....)
Fixed up some naming
Files weren't added to .xcodeproj, build was failing


          Clean up reactions settings

8164c8b

rnystrom merged commit 28b76e6 into master

rnystrom deleted the reactions-cleanup branch

August 11, 2018 17:50

Collaborator

Huddie commented Aug 12, 2018 •

edited

Loading

@rnystrom Yicks. My bad. Thanks for fixing it up. I can see how that last one could be a bit of an issue lol

_{Sent with GitHawk}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet