Choose double tap #2022
Choose double tap #2022
Conversation
| UserDefaults.setDefault(reaction: reaction) | ||
| defaultReactionLabel.text = reaction.emoji | ||
| } | ||
| } |
There was a problem hiding this comment.
Fine merging this as-is, but if we're going to put stuff in an extension, we might as well put it in another file. We don't really follow the trend of making extensions for everything in this project.
There was a problem hiding this comment.
I'll just remove the extension no biggy.
| let menu = UIMenuController.shared | ||
| menu.menuItems = actions.map { UIMenuItem(title: $0.0, action: $0.1) } | ||
| menu.setTargetRect(defaultReactionLabel.frame, in: setDefaultReaction) | ||
| menu.setMenuVisible(true, animated: trueUnlessReduceMotionEnabled) |
There was a problem hiding this comment.
Using UIMenuController to pick a selection in Settings feels really weird. Could we instead create a new UITableViewController that has all of the emoji options, and you select a cell?
There was a problem hiding this comment.
@rnystrom Context Menu type thing or you want a whole new view controller?
There was a problem hiding this comment.
While new view controller. Like how on settings sub menus are just a simple list:
|
This has been updated to the following! Minor wording changes were made after these screenshots (Leave this by double -> Leave this when double) either way could work, let me know quick fix. And Smiley was changed to Laugh for the emoji name.
|
|
Cells have switched to styledTextCells to match the rest of settings page |
|
Couple more UX things:
|
|
@rnystrom Ya I don't mind having it under GitHawk I think that the issues I ref above just spoke about the fact that settings arent really broken up that much and it could use a few more sections to make it easier to navigate. The GitHawk section seems to contain settings that pertain to GitHawk as an app (Report a bug, view source code, write a review) As well as settings that pertain to the specfic users app (Badge Unread, Read on Open, and if reactions, reactions) So half are about customizing your version of GitHawk half are about GitHawk itself. Maybe we break these up into 2 sections. GitHawk and Customize? |
|
Ill shift it into GitHawk section and I guess breaking the section up can become an issue or really it should pick up from the already created issue that discusses it |
|
@rnystrom Okay those UX fixes + I changed how none/disabled enabled worked. |
|
New enable/disable UI Sent with GitHawk |
|
Also addresses #1970 |
|
Looks awesome! I'm about to cut + ship the latest version. Going to hold on landing this until we ship so we have enough time to dogfood this. |
|
Awwww man! Haha sounds good. Looking forward to the next release! |
|
Looks amazing @Huddie! 😍 |
|
Thanks @BasThomas! |
|
Gonna take it and give it a whirl 😄 |
3 participants
Allowing users to choose the reaction that occurs when double tapping on a comment