Enable fs exe projects #1894
Closed
Enable fs exe projects #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork to head repo
|
Can you squash and rebase on top of master? |
added 4 commits
November 7, 2019 10:58
CompileBefore Include is used for F# projects to include the generated AssemblyInfo and GitVersionInfo files in the project before any already included fs source files. This is accomplished with a conditional F# check on the language property.
|
I will close this PR and create a new one that is squashed and ready to be rebased on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly fixes #1831.
What works:
Both exe and dll fsproj projects can use GitVersionTask and assemblies get version info when building in VisualStudio2019.
What does not work yet:
Neither dlls or exes get version info when build using
dotnet buildcli (3.0.100). This seems to be a bug in the dotnet core fsharp compiler atm. dotnet/fsharp#7220Testing
Unfortunately I haven't found an easy way to automate testing of this.
I've created a test solution with both a csproj and a fsproj https://github.com/da9l/testgitversiontask4fsexe.git where I've tested this manually.
Note: This is my third attempt since the two first got rejected by chocolatey pack due to long branch name. I apologize for the mess.