Enable F# exe projects to use GitVersionTask #1896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update fork to head repo
For F# projects the generated AssemblyInfo and GitVersionInformation fs files are added before already included source files using CompileBefore Include instead of Compile Include. This is done in two ItemGroups with a F# condition on the language property.
|
Thank you so much for your contributions, @da9l 👍. Can you try version 5.1.2-beta.1+13 when it's available and confirm it's working? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partly fixes #1831.
What works:
Both exe and dll fsproj projects can use GitVersionTask and assemblies get version info when building in VisualStudio2019.
What does not work yet:
Neither dlls or exes get version info that is visible in the file properties in windows when built using
dotnet buildcli (3.0.100). This seems to be a bug in the dotnet core fsharp compiler atm. dotnet/fsharp#7220Testing
Unfortunately I haven't found an easy way to automate testing of this.
I've created a test solution with both a csproj and a fsproj https://github.com/da9l/testgitversiontask4fsexe.git where I've tested this manually.