Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include stdout and stderr #1341

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

arturcic
Copy link
Member

@arturcic arturcic commented Nov 18, 2024

This pull request includes changes to the src/tools directory to enhance the CLI tool's functionality and improve type safety. The most important changes include updating imports, modifying the run function to handle process outputs, and ensuring proper type usage.

Enhancements to CLI tool functionality:

  • src/tools/cli.ts: Updated imports to include run and removed getToolRunner. Modified the run call to cast command as Commands.

  • src/tools/lib.ts: Added process import for handling process outputs. Updated the run function to write stdout and stderr to the process streams and exit with the appropriate code. [1] [2]

@arturcic arturcic force-pushed the fix/include-sdtout-stderr branch from 1e3b7e7 to 5788f8a Compare November 18, 2024 00:45
@arturcic arturcic linked an issue Nov 18, 2024 that may be closed by this pull request
2 tasks
@arturcic arturcic merged commit 000e20d into GitTools:main Nov 18, 2024
11 of 13 checks passed
@arturcic arturcic deleted the fix/include-sdtout-stderr branch November 18, 2024 00:58
Copy link
Contributor

mergify bot commented Nov 18, 2024

Thank you @arturcic for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant