Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert logging to stdout and stderr (fix for #1344) #1349

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

arturcic
Copy link
Member

@arturcic arturcic commented Nov 20, 2024

Partially reverts #1341
Reopens #1224 #1229

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (1)

src/tools/cli.ts:4

  • The removal of type casting 'command as Commands' could potentially introduce issues if 'command' is not of the expected type. Ensure that 'command' is correctly typed.
await run(agent, tool, command)
@arturcic arturcic merged commit b142ba2 into GitTools:main Nov 20, 2024
13 checks passed
@arturcic arturcic deleted the fix/revert-1341 branch November 20, 2024 04:56
Copy link
Contributor

mergify bot commented Nov 20, 2024

Thank you @arturcic for your contribution!

@arturcic arturcic changed the title Revert logging to stdout and stderr Revert logging to stdout and stderr (fix for #1344) Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE]: Overwriting readonly variable 'GitVersion.Major' is not permitted
1 participant