fix: Make cargo check to pass all tests #865

nyurik · 2023-05-25T00:02:49Z

This command was failing:

cargo check  --benches --examples --tests --lib --bins --workspace

I think it would be easier to just use the cargo -p <crate> syntax in CI, instead of requiring cd ...?

This command was failing: ```bash cargo check --benches --examples --tests --lib --bins --workspace ```

Byron

Thanks a lot (for all these improvements)!

I am trying to figure out what's happening with CI here as it now seems to fail consistently on one test, which unfortunately doesn't reproduce locally. Once I fixed that, I will happily merge this PR.

Make cargo check to pass all tests

f4a44f7

This command was failing: ```bash cargo check --benches --examples --tests --lib --bins --workspace ```

nyurik changed the title ~~Make cargo check to pass all tests~~ fix: Make cargo check to pass all tests May 25, 2023

nyurik mentioned this pull request May 25, 2023

Include custom clippy settings #867

Merged

Byron approved these changes May 25, 2023

View reviewed changes

Byron merged commit 3a45973 into GitoxideLabs:main May 25, 2023

nyurik deleted the fix-tests branch May 25, 2023 16:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Make cargo check to pass all tests #865

fix: Make cargo check to pass all tests #865

nyurik commented May 25, 2023 •

edited

Loading

Byron left a comment •

edited

Loading

fix: Make cargo check to pass all tests #865

fix: Make cargo check to pass all tests #865

Conversation

nyurik commented May 25, 2023 • edited Loading

Byron left a comment • edited Loading

Choose a reason for hiding this comment

nyurik commented May 25, 2023 •

edited

Loading

Byron left a comment •

edited

Loading