-
-
Notifications
You must be signed in to change notification settings - Fork 339
Include custom clippy settings #867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* All custom clippy settings are now centralized * add `make fix-clippy` for automated fixes * Modified some simple cases, e.g. use `_` instead of `true|false` in a match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot (for all these improvements)!
I am loving the new clippy target and will merge once having sorted the makefile
TODO. Also I will re-evaluate the justfile
, even though last time I still preferred the simplicity and ubiquitousness of makefiles.
Also, I think it would be better to use
cargo -p <project>
in the makefile and elsewhere - this way it will be cleaner to repeate the broken CI step without thecd ...
, and also will not require the test to contain some non-buildable paths - see #865
I will also take a look at this, and agree that -p
is underused here. Admittedly, back in the days I wasn't aware of it.
Regarding I check the manual to get some issues clarified:
It's a bit sad to see that the listing isn't as pretty as the one-liner that is used here with ![]() ![]() Yes, so I think I will have some fun porting the |
Thanks again for all your work here! I will see if not changing directory I will start a new PR for transcribing the makefile in a moment right after merging once CI is green, excitement! |
Help needed: no idea why tests fail in all of my PRs :(
make fix-clippy
for automated fixes_
instead oftrue|false
in a matchUnrelated to this specific change, but I would highly recommend to use justfile -- much cleaner and easier.
Also, I think it would be better to use
cargo -p <project>
in the makefile and elsewhere - this way it will be cleaner to repeate the broken CI step without thecd ...
, and also will not require the test to contain some non-buildable paths - see #865