-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable 'Autoplay' on videos recorded into Milestones #740
Comments
Another example here I think we did this already on the Wall of Fame - now that we are loading the videos directly to the Milestone the same change is needed in the DApp. |
30 DAI Bounty? |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 30.0 DAI (30.0 USD @ $1.0/DAI) attached to it as part of the Giveth fund.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 1 month ago. 1) wenheli has applied to start work (Funders only: approve worker | reject worker). Interested in this work! I can start it right now if nobody is working on it yet! Find the reason for it not autostopping. Rectify the issue. From what I've seen so far, you cannot delete the autoplay attribute directly. The videos are being loaded from a different web page (ipfs) using an iframe element. There's no actual A potential alternative is to use the removeAttribute() from html DOM. I believe it should be possible to access the Thank you for creating a bounty for such an accessible issue. I have been wanting to get started with gitcoin but haven’t found a good place to start. Until now that is! As for the plan, I believe removing the autoPlay attribute from the video element would do the trick. This would prevent the video from automatically playing (go figure). I love what you all are doing with Giveth and will be looking to contribute regardless of wether or not I am assigned this bounty. Thanks for your time, Hey, I can do it really quiclky follow web standard and cross device hi ' It seems the video is loaded from IPFS and it is loaded inside iframe we cannot access the video I would like to work on the issue and see if there is any possible solution. Thanks. Learn more on the Gitcoin Issue Details page. |
@GriffGreen guess this line should be removed. Can do it real quick. |
@GriffGreen [View Signed NDA] functionality is broken on Gitcoin ;( |
@ I think, I found the problem the milestone's description is stored in db as iframe element ( back-end solution ) Which can be solved by converting the back-end code to store and return as video tag or ( front-end solution ) we can transform that description to video element here like this by extracting the source from the iframe source and assign it to the video source
I can raise a pull request with the required fix from the front-end side solution. Currently, waiting for the approval in gitCoin. |
@nadirlaskar Ok you are approved! |
@nadirlaskar Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!
Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days |
@GriffGreen I have submitted a PR with changes |
I have submitted a PR with changes, I will submit work in Gitcoin as soon as I have some ETH for gas price. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 30.0 DAI (30.0 USD @ $1.0/DAI) has been submitted by: @GriffGreen please take a look at the submitted work:
|
still testing it... will be done this week |
D |
See Josh Fairhead's RewardDAO Feb Milestone as example (and to check out his mad skillz in the juggling department).
It's rather disconcerting to open the Milestone and have the video begin playing automatically.. can this setting be disabled so I can click play when I'm ready to hear it?
The text was updated successfully, but these errors were encountered: