-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX #740, Disable 'Autoplay' on videos recorded into Milestones #757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As server is sending video source of milestone video as description inside iframe tag. Which generates a video element by browser inside iframe having auto-play and other controls enabled by default leading to the auto-play issue. As part of the front-end only fix, here i am converting the iframe to a video tag by reading the iframe source and applying it to the video element.
Deploy preview for giveth-dapp processing. Building with commit a697336 https://app.netlify.com/sites/giveth-dapp/deploys/5cedf9b4b8fa3b0009dbf494 |
nadirlaskar
changed the title
FIX #740, Disable 'Autoplay' on videos recorded into Milestones
WIP #740, Disable 'Autoplay' on videos recorded into Milestones
May 6, 2019
Instead of using jquery to read iframe src attribute, modified to using regex to extract the attribute.
In order to not mutate the state of the component, making a copy of description for transforming and passing it to create react node.
nadirlaskar
changed the title
WIP #740, Disable 'Autoplay' on videos recorded into Milestones
FIX #740, Disable 'Autoplay' on videos recorded into Milestones
May 6, 2019
There seems to be some error with CI due to following files,
... |
Some cases the description value of the milestone is set to undefined, added a if condition to check for that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Problem is that the milestone's description is stored in db as iframe element
<iframe class="ql-video" frameborder="0" allowfullscreen="true" src="https://ipfs.giveth.io/ipfs/xxxxxxxxxxx"></iframe><p><br /></p>"
( back-end solution )
Which can be solved by converting the back-end code to store and return as video tag
<video controls="" autoplay="false" name="media"><source src="https://ipfs.giveth.io/ipfs/xxxxxxxxxxx" type="video/webm"></video>
or ( front-end solution )
we can transform that description to video element here like this by extracting the source from the iframe source and assign it to the video source
In this pull request, I changed files required to fix from the front-end side solution.