Fixing Travis Integration so contributors stop wasting their time

[GriffGreen]

#757 (comment)
This is an issue... we have travis doing checks but the checks fail... we need to better maintain this. We are wasting every contributors time when this check fails :-(

[nadirlaskar]

It seems there is some problem with eslint check in the build process

20.92s$ npm run eslint
> giveth-dapp@0.1.0 eslint /home/travis/build/Giveth/giveth-dapp
> eslint 'src/**/*.js*'
/home/travis/build/Giveth/giveth-dapp/src/components/ArchiveMilestoneButton.jsx
  87:9  warning  Unexpected console statement  no-console
/home/travis/build/Giveth/giveth-dapp/src/components/BackupWalletButton.jsx
  20:15  error  Replace `⏎······Array.isArray(wallet.keystores)·&&⏎·····` with `·Array.isArray(wallet.keystores)·&&`  prettier/prettier
  23:7   error  Delete `··`                                                                                           prettier/prettier
  24:1   error  Replace `··········` with `········`                                                                  prettier/prettier
  25:9   error  Delete `··`                                                                                           prettier/prettier
  26:1   error  Replace `··········` with `········`  

Some components are having inconsistent spaces i believe, which is failing the eslint check

[GriffGreen]

@nadirlaskar how much would you charge us to fix this?

[nadirlaskar]

@nadirlaskar how much would you charge us to fix this?

There are 45 files having lint issue in the repo right now, some files are fixable with eslint --fix, others require manual changes.

Some files are using label without htmlFor attribute, fix requires updating the property where possible or replace with <span className="label"></span>

Also some update is required in eslint & eslint:fix script in package.json

Test cases are inconsistent with the models, update to the test case required to make it consistent.

All changes are possible to be completed in 2 hrs,
I can start working on a pull request for the described fixes for 60 DAI

[nadirlaskar]

@nadirlaskar how much would you charge us to fix this?

I have opened a pull request with a fix, check it out @GriffGreen

[GriffGreen]

NICE! Whats your Ethereum address? we are making a milestone for you in the dapp ;-D George or Andre will review :-D

[nadirlaskar]

NICE! Whats your Ethereum address? we are making a milestone for you in the dapp ;-D George or Andre will review :-D

@GriffGreen This will be my meta mask etherium address 0x039dACca4a447E140d8B29F0652cd844Ea827D1a

[nadirlaskar]

NICE! Whats your Ethereum address? we are making a milestone for you in the dapp ;-D George or Andre will review :-D

@GriffGreen Yay! Thanks :)
@ElMejorge I am available for any clarifications on pull request.

[nadirlaskar]

NICE! Whats your Ethereum address? we are making a milestone for you in the dapp ;-D George or Andre will review :-D

@GriffGreen
The issue looks closed, when can I expect the bounty?

[GriffGreen]

:-D! Sorry for the delay! I'll get @mroberts10 to make this happen asap

[GriffGreen]

https://beta.giveth.io/campaigns/5b39d45e14cec916d00dab20/milestones/5ce2d8182bb8c0257c7b83c5

[nadirlaskar]

:-D! Sorry for the delay! I'll get @mroberts10 to make this happen asap

Thanks, that will be great! :-)

[nadirlaskar]

https://beta.giveth.io/campaigns/5b39d45e14cec916d00dab20/milestones/5ce2d8182bb8c0257c7b83c5

@GriffGreen I see there is no recipient for the milestone, this is my eth address.

[GriffGreen]

Sorry about that delay @nadirlaskar ! its up now tho! https://beta.giveth.io/campaigns/5b39d45e14cec916d00dab20/milestones/5ce2d8182bb8c0257c7b83c5

[GriffGreen]

I sent a little extra eth to you to make up for the delay (That DAI could have been on Compound making interest!)
https://etherscan.io/tx/0xec91ea58a4151575c99009989b5c44b6a1015c41c0d9af76a75eacba294ec5b6