Skip to content

Commit

Permalink
fix: 🐛 continue check if circular dep is detected (#184)
Browse files Browse the repository at this point in the history
instead of returning if a circular dependency is detected the loop should continue with the next entry.
  • Loading branch information
KANAjetzt authored Mar 24, 2023
1 parent 40ae4f1 commit 93e6cab
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions addons/mod_loader/mod_loader.gd
Original file line number Diff line number Diff line change
Expand Up @@ -135,9 +135,7 @@ func _init() -> void:
var mod: ModData = mod_data[dir_name]
if not mod.is_loadable:
continue
var is_circular := _check_dependencies(mod)
if is_circular:
return
var _is_circular := _check_dependencies(mod)

# Sort mod_load_order by the importance score of the mod
mod_load_order = _get_load_order(mod_data.values())
Expand Down

0 comments on commit 93e6cab

Please sign in to comment.