Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 Always use warnings for deprecations in standalone builds #276

Merged

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Jun 13, 2023

There seems to be an issue where deprecations can cause mods to stop working even through the assert from log-fatal should be removed.
To circumvent this, turn all deprecations into warnings for standalone (non-editor) builds

@Qubus0 Qubus0 added the bug Something isn't working label Jun 13, 2023
@Qubus0 Qubus0 added this to the v6.0.0 milestone Jun 13, 2023
Copy link
Member

@otDan otDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@Qubus0 Qubus0 added this pull request to the merge queue Jun 13, 2023
Merged via the queue into GodotModding:development with commit 8f030b2 Jun 13, 2023
@Qubus0 Qubus0 deleted the warn_deprecation_on_standalone branch June 13, 2023 21:44
@KANAjetzt KANAjetzt mentioned this pull request Jun 13, 2023
15 tasks
@ithinkandicode ithinkandicode changed the title fix: always use warnings for deprecations in standalone builds fix: 🐛 Always use warnings for deprecations in standalone builds Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants