refactor: ♻️ reworked disabling mods via user profile #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KANAjetzt
force-pushed
the
refactor_user_profile_disable_mod
branch
from
c587953
to
820fbd2
Compare
Qubus0
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_activeproperty toModData._update_mod_list()that enables mods that are inModLoaderStore.mod_data(previously disabled mods did not end up in
ModLoaderStore.mod_data).Breaking Change:
With the recent update, mods are now always unpacked and loaded into
ModLoaderStore.mod_data. This change can potentially break Mod Lists that rely on having only loaded mods inmod_data. Consequently, these Mod Lists may display mods that are currently not loaded. To address this issue, authors of Mod Lists need to adapt their code to check the newis_activeflag for each mod.closes #286