Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to snake case #32

Merged
merged 2 commits into from
Jan 15, 2023
Merged

Convert to snake case #32

merged 2 commits into from
Jan 15, 2023

Conversation

ithinkandicode
Copy link
Collaborator

Changes the old camelCase func names to snake_case.

This is a breaking changes for all mods.

Old New
installScriptExtension install_script_extension
addTranslationFromResource add_translation_from_resource
appendNodeInScene append_node_in_scene
saveScene save_scene

Qubus0
Qubus0 approved these changes Jan 15, 2023
View reviewed changes
Copy link
Collaborator

@Qubus0 Qubus0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. don't forget _savedObjects L95 though

@ithinkandicode ithinkandicode merged commit 1dcaa62 into GodotModding:main Jan 15, 2023
@ithinkandicode ithinkandicode deleted the snake-case branch January 17, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Qubus0 Qubus0 Qubus0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ithinkandicode @Qubus0