Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ added refresh_config_data() and `refresh_current_c… #374

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

KANAjetzt
Copy link
Member

Allows refreshing of config data at any time during runtime.

Adds 2 new functions:

func refresh_config_data(config: ModConfig) -> ModConfig:
Refreshes the data of the provided configuration by reloading it from the config file.

func refresh_current_configs() -> void:
Iterates over all mods to refresh the data of their current configurations, if available.
Compares the previous configuration data with the refreshed data and emits the current_config_changed signal if changes are detected.

@KANAjetzt KANAjetzt added enhancement New feature or request 4.x labels Mar 21, 2024
@KANAjetzt KANAjetzt added this to the 4.x - 6.3.0 milestone Mar 21, 2024
@KANAjetzt KANAjetzt requested review from Qubus0, otDan and a team March 21, 2024 15:24
@KANAjetzt KANAjetzt self-assigned this Mar 21, 2024
@KANAjetzt KANAjetzt force-pushed the feat_config_refresh branch from a6b83fe to 2d2ba3d Compare March 21, 2024 15:33
Allows refreshing of config data at any time during runtime.
@KANAjetzt KANAjetzt force-pushed the feat_config_refresh branch from 2d2ba3d to b2e6ca6 Compare March 21, 2024 15:36
@KANAjetzt KANAjetzt added this pull request to the merge queue Mar 22, 2024
Merged via the queue into GodotModding:4.x with commit b780ae7 Mar 22, 2024
1 check passed
@KANAjetzt KANAjetzt deleted the feat_config_refresh branch March 22, 2024 18:02
@KANAjetzt KANAjetzt modified the milestones: 4.x - 6.3.0, 4.x - 7.0.0 Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants