fix: 🐛 fixed missing script parent path #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added a comparator method to sort extensions of the same script added a comparator method to sort extensions of the same script following the load order * added a table to avoid iterating through the load order every comparison * style edits/spacing changes renamed a var, added spacing to keep the style consistency * style: added an empty line * changed get_string_in_between to get_mod_dir * better description for get_mod_dir
Before, if the same script was extended multiple times, the `parent_script_path` would be empty for all extensions except the first one.
Qubus0
approved these changes
Apr 5, 2024
KANAjetzt
added a commit
to KANAjetzt/godot-mod-loader
that referenced
this pull request
Jan 25, 2025
* feat: script extensions sorter checks load order (GodotModding#357) * added a comparator method to sort extensions of the same script added a comparator method to sort extensions of the same script following the load order * added a table to avoid iterating through the load order every comparison * style edits/spacing changes renamed a var, added spacing to keep the style consistency * style: added an empty line * changed get_string_in_between to get_mod_dir * better description for get_mod_dir * fix: 🐛 fixed missing script parent path Before, if the same script was extended multiple times, the `parent_script_path` would be empty for all extensions except the first one. * fix: ✏️ removed no longer accurate comment
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 26, 2025
fix: 🐛 fixed missing script parent path (#383) * feat: script extensions sorter checks load order (#357) * added a comparator method to sort extensions of the same script added a comparator method to sort extensions of the same script following the load order * added a table to avoid iterating through the load order every comparison * style edits/spacing changes renamed a var, added spacing to keep the style consistency * style: added an empty line * changed get_string_in_between to get_mod_dir * better description for get_mod_dir * fix: 🐛 fixed missing script parent path Before, if the same script was extended multiple times, the `parent_script_path` would be empty for all extensions except the first one. * fix: ✏️ removed no longer accurate comment
KANAjetzt
added a commit
that referenced
this pull request
Jan 26, 2025
fix: 🐛 fixed missing script parent path (#383) * feat: script extensions sorter checks load order (#357) * added a comparator method to sort extensions of the same script added a comparator method to sort extensions of the same script following the load order * added a table to avoid iterating through the load order every comparison * style edits/spacing changes renamed a var, added spacing to keep the style consistency * style: added an empty line * changed get_string_in_between to get_mod_dir * better description for get_mod_dir * fix: 🐛 fixed missing script parent path Before, if the same script was extended multiple times, the `parent_script_path` would be empty for all extensions except the first one. * fix: ✏️ removed no longer accurate comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #382