Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: logging without store #499

Closed
wants to merge 1 commit into from
Closed

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Dec 25, 2024

Removes all variables from ModLoaderStore to ModLoaderLog - as static variables
also added @tool since there are a few cases popping up that make use of the logger in editor (like the mod tool)

that should also let us remove is_silent from a few functions like is_name_or_namespace_valid if we want to.

supersedes and closes #456

works towards

@Qubus0 Qubus0 added bug Something isn't working enhancement New feature or request deprecation 4.x labels Dec 25, 2024
@Qubus0 Qubus0 requested a review from KANAjetzt December 25, 2024 16:08
@Qubus0 Qubus0 self-assigned this Dec 25, 2024
@Qubus0 Qubus0 changed the base branch from main to 4.x December 25, 2024 16:08
@Qubus0
Copy link
Collaborator Author

Qubus0 commented Dec 25, 2024

replaced by #500

@Qubus0 Qubus0 closed this Dec 25, 2024
@Qubus0 Qubus0 deleted the feat/logging-without-store branch December 25, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x bug Something isn't working deprecation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant