Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing logging in mod manifest #72

Merged

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Jan 21, 2023

Used log_fatal everywhere because the mod won't be loaded with these things being invalid. Avoids missing the error in the console and wondering why the mod did not load

@Qubus0 Qubus0 requested a review from a team January 21, 2023 11:04
@Qubus0 Qubus0 merged commit 81ce17e into GodotModding:develop Jan 21, 2023
@Qubus0 Qubus0 deleted the fix_missing_logging_in_mod_manifest branch January 21, 2023 13:58
@ithinkandicode ithinkandicode mentioned this pull request Feb 22, 2023
@KANAjetzt KANAjetzt mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants