Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global class registration #95

Merged
merged 3 commits into from
Feb 5, 2023

Conversation

Qubus0
Copy link
Collaborator

@Qubus0 Qubus0 commented Feb 4, 2023

fix: prevent duplicate global class registration
refactor: utils global class registration does not save anymore, mod_loader exposes a new method for mods to use it and save

@Qubus0 Qubus0 added the bug Something isn't working label Feb 4, 2023
@Qubus0 Qubus0 requested review from KANAjetzt and a team February 4, 2023 12:50
@Qubus0 Qubus0 requested a review from KANAjetzt February 4, 2023 22:21
Copy link
Member

@KANAjetzt KANAjetzt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty 👍

@Qubus0 Qubus0 merged commit 6eaf052 into GodotModding:develop Feb 5, 2023
@Qubus0 Qubus0 mentioned this pull request Feb 5, 2023
@Qubus0 Qubus0 deleted the fix_global_class_registration branch February 5, 2023 10:35
@ithinkandicode ithinkandicode mentioned this pull request Feb 22, 2023
@KANAjetzt KANAjetzt mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants