-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.31 Support #45
1.31 Support #45
Conversation
Fix for broken songcore
1.29 support (Graph API)
Game removed this lib, we have to bundle our own.
Game removed this lib, we have to bundle our own.
Improvements, fixes, changes 1.30.2
This is a somewhat hacky mix of multiplexing and heuristics, but is necessary for players with MultiplayerCore installed (see Goobwabber/MultiplayerCore#45)
I've made some changes to this and the BeatTogether client PR to address feedback re: encryption and settings. Regarding the SSL setting:
ServerBrowser, unrelated to these changes:
|
I take issue with having defaults incompatible with Official servers. Protocol extensions like this should build on the source seamlessly, not requiring hard-coded edge cases like |
I don't disagree from a purist perspective. But pragmatically speaking, this default makes the most sense to me for third-party servers as I expect they will generally not do DTLS. Extended server status data is not used for official servers at all, because all mods do indeed have special handling for official. I think "if official, disable modded extensions" type logic will always exist and is not unreasonable. Flipping the default would have no effect except that it might be "more correct" and would require explicit opt-out from modded servers. |
Modded servers already have an explicit opt-out. The only status responses not containing a |
I've further updated this PR to 1.34, when will this be merged? I don't want to submit my own PR and take @roydejong's credit for their code until this PR has been merged. |
@roydejong would it be fine if we merge this into our dev branch instead of main, then we can open a new PR for 1.34.0 |
Sounds good, merging into dev |
This PR adds support for Beat Saber 1.31:
DisableSsl
patch to bypass SSL / encryption / certificate checks on Ignorance/ENet connectionsenvironmentInfos
)use_ssl
/useSsl
in multiplayer status data, addMpStatusRepository
to allow BeatTogether to access this