misc(viewer): fix saving as gist (#5251)

GoogleChrome · May 17, 2018 · 46e49f4 · 46e49f4
1 parent 4a046e0
commit 46e49f4
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lighthouse-core/report/html/renderer/report-ui-features.js b/lighthouse-core/report/html/renderer/report-ui-features.js
@@ -291,7 +291,7 @@ class ReportUIFeatures {
 
     const el = /** @type {?Element} */ (e.target);
 
-    if (!el || el.hasAttribute('data-action')) {
+    if (!el || !el.hasAttribute('data-action')) {
       return;
     }
 

diff --git a/lighthouse-core/scripts/roll-to-devtools.sh b/lighthouse-core/scripts/roll-to-devtools.sh
@@ -18,7 +18,7 @@ chromium_dir="$HOME/chromium/src"
 if [[ -n "$1" ]]; then
   frontend_dir="$1"
 else
-  frontend_dir="$chromium_dir/third_party/WebKit/Source/devtools/front_end"
+  frontend_dir="$chromium_dir/third_party/blink/renderer/devtools/front_end"
 fi
 
 if [[ ! -d "$frontend_dir" || ! -a "$frontend_dir/Runtime.js" ]]; then

diff --git a/lighthouse-viewer/app/src/github-api.js b/lighthouse-viewer/app/src/github-api.js
@@ -36,7 +36,7 @@ class GithubApi {
     return this._auth.getAccessToken()
       .then(accessToken => {
         const filename = getFilenamePrefix({
-          url: jsonFile.url,
+          finalUrl: jsonFile.finalUrl,
           fetchTime: jsonFile.fetchTime,
         });
         const body = {