extension: expose URL shim (#5293)

lighthouse-core/lib/url-shim.js

@@ -132,6 +132,7 @@ class URLShim extends URL {
   }
 }
 
+URLShim.URL = URL;
 URLShim.URLSearchParams = (typeof self !== 'undefined' && self.URLSearchParams) ||
     require('url').URLSearchParams;
 

lighthouse-extension/gulpfile.js

@@ -141,6 +141,12 @@ gulp.task('browserify-lighthouse', () => {
         bundle = bundle.require(artifact, {expose: artifact.replace(corePath, './')});
       });
 
+      // browerify's url shim doesn't work with .URL in node_modules,
+      // and within robots-parser, it does `var URL = require('url').URL`, so we expose our own.
+      // @see https://github.com/GoogleChrome/lighthouse/issues/5273
+      const pathToURLShim = require.resolve('../lighthouse-core/lib/url-shim.js');
+      bundle = bundle.require(pathToURLShim, {expose: 'url'});
+
       // Inject the new browserified contents back into our gulp pipeline
       file.contents = bundle.bundle();
     }))

lighthouse-extension/test/extension-test.js

@@ -170,4 +170,9 @@ describe('Lighthouse chrome extension', function() {
     const errors = auditErrors.filter(item => item.debugString.includes('Audit error:'));
     assert.deepStrictEqual(errors, [], 'Audit errors found within the report');
   });
+
+  it('should pass the is-crawlable audit', async () => {
+    // this audit has regressed in the extension twice, so make sure it passes
+    assert.ok(await extensionPage.$('#is-crawlable.lh-audit--pass'), 'did not pass is-crawlable');
+  });
 });