extension: expose URL shim #5293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
reviewed
May 22, 2018
lighthouse-extension/gulpfile.js
Outdated
| // browerify's url shim doesn't work with .URL in node_modules, so expose our own | ||
| // @see https://github.com/GoogleChrome/lighthouse/issues/5273 | ||
| const pathToURLShim = require.resolve('../lighthouse-core/lib/url-shim.js'); | ||
| bundle = bundle.require(pathToURLShim, {expose: 'url'}); |
There was a problem hiding this comment.
where is this lowercase usage of it used? i'm not following what the fix is here.
There was a problem hiding this comment.
inside robots-parser it does var URL = require('url').URL
| @@ -132,6 +132,7 @@ class URLShim extends URL { | |||
| } | |||
| } | |||
|
|
|||
| URLShim.URL = URL; | |||
There was a problem hiding this comment.
robots parser, see above :)
brendankenny
approved these changes
May 23, 2018
There was a problem hiding this comment.
well, this definitely only adds to the url-shim browserify confusion but I can't think of a better solution so LGTM :)
we do expose ourselves to some possible future bugs if we end up using a module that uses require('url').parse() or whatever, but there's not a great solution available and hopefully everyone will be using the global URL soon enough...
This was referenced Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues/PRs
fixes #5273