-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve LHR API shape for downstream consumers #4614
Comments
Current Plan:
|
First build from this 3.0 effort. The build is based on this branch, which is 3 trivial commits beyond #4616. |
This was referenced Mar 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have downstream consumers of Lighthouse data that want to use the details within
extendedInfo
and/ordetails
.However there are a few problems that make it difficult:
details
currently ships mostly strings like "42 ms". consumers gotta parse a number out of there. :/details
requires relying on array indices and looking up those locations from aitemHeaders
(which also doesn't offer reliable key names)extendedInfo
we've never made promises on, but much of the good stuff is there. (we know, as we use it almost exclusively for unit tests)Fixing this is a breaking change (Hello #4333!), but it's worth it.
Background doc: AuditResults Data format discussion
The text was updated successfully, but these errors were encountered: