Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LH dep to v3 #158

Closed
denar90 opened this issue Mar 10, 2018 · 2 comments
Closed

Update LH dep to v3 #158

denar90 opened this issue Mar 10, 2018 · 2 comments

Comments

@denar90
Copy link
Collaborator

denar90 commented Mar 10, 2018

We should prepare our codebase to LH v3.

  1. Take a look at LHR details core(lhr): overhaul LHR details, introduce details.summary GoogleChrome/lighthouse#4616
  2. Improve code and tests
@denar90 denar90 mentioned this issue Mar 10, 2018
Closed
@paulirish
Copy link
Owner

I'd say hold off for a moment. While I have a few PRs that are about to land, the bigger change will be when we nuke extendedInfo.

Around that time, we'll ask you guys how you'd prefer to pull in the timing/timestamp values.. as there's a few ways we could do it.

And here's two slightly better links than 4616:

GoogleChrome/lighthouse#4614 (comment)
GoogleChrome/lighthouse#4333

@denar90 denar90 mentioned this issue Mar 24, 2018
Closed
@denar90
Copy link
Collaborator Author

denar90 commented Sep 12, 2018

We can close this one since #178 merged

@denar90 denar90 closed this as completed Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulirish @denar90