☂️ 👣 Things to fix on next breaking change

[patrickhulce]

Non-Comprehensive List of Things We Should Fix on Next Breaking Change .

Update: everything open below is now represented in #5008

Audit Rejiggers

• Remove cache-start-url audit (unused)
• rename "uses-request-compression" to "uses-text-compression" :)
• combine render blocking scripts/stylesheets audits to just "render-blocking resources"
• change EIL to use rolling window
• onLoad -> load
• speed-index-metric -> speed-index
• use speedIndex instead of perceptualSpeedIndex
• move computedArtifacts off of the artifacts object (onto auditContext?)

LHR formalization

• Ensure all audits return a numeric score (0-1), no boolean nonsense. scoreDisplayMode forces how it's displayed core(lhr): strictly numeric scores, add scoreDisplayMode #4690
• Ship more numbers and less strings. core: improved consumption of audit.details #4384
• Make details real and good. core(lhr): overhaul LHR details, introduce details.summary #4616
• Remove extendedInfo
  • Update all those tests
  • add a metrics.js audit that contains all timings/timestamps in its details, so all the things don't need to reach into FMP.extInfo
  • take inventory of extendedInfo data that's currently not in the associated details block, but should be. (here's what HA uses, what brendan uses)
• de-dupe all audit results (only have each audit represented once) (see Update programmatic example to delete results.artifacts #4346 (comment)). aka slim reportCategories #core(lhr): overhaul LHR details, introduce details.summary #4616
• kill displayValue and use details for it.
• audit.description -> audit.title, helpText -> description, name -> id
• make type: 'list' a table
• make type: 'cards' a table
• generatedTime -> fetchedAt
• do fallbackKey/fallbackType for multi-typed columns (code snippets sometimes instead of URLs)?
• introduce type:'metric' and type:'opportunity' as expressed in the LHR Lite doc
• add config settings to LHR, move human-friendlier runtimeConfig to the report generating stage

Config

• fix allowed config representations (config v2 😃 , i.e. no more audits: ['path/my-audit'] -> audits: { 'my-audit': {path: 'path/to/audit'}})
• rename perf-hint, perf-info
• delete configjson.artifacts, use settings.auditMode instead to load artifacts from disk (should be just a type update)

Also

• Use LHError for all thrown errors when possible (connections/cri.js for example)
• replace --perf with a real mechanism for using full/perf/mixed-content configs
• drop support for node <8
• support output: 'html'/'csv' from node module
• node module return is {lhr, artifacts}

CLI

• no more --disable-network-throttling --disable-cpu-throttling, use --throttling-method=provided or --throttling.cpuSlodownMultiplier=1 or --throttling.requestLatencyMs=0

Maybe

• change device from Nexus 5X to Pixel?

[wardpeet]

Should we upgrade to node 8 as well?

[ebidel]

How about #1999

[patrickhulce]

@ebidel yup for sure, both these target #1999

• "Kill off" extendedInfo and make details real and good.
• de-dupe all audit results

[brendankenny]

we should remove chrome-launcher/. Kept only to preserve various places we suggested calling deep into our directory structure

[paulirish]

#5008 has to be dealt with but this is a duplicate now