cli(chrome-launcher): remove chrome-launcher forwarding stubs #4945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Apr 10, 2018
| @@ -5,7 +5,7 @@ | |||
| "main": "./lighthouse-core/index.js", | |||
| "bin": { | |||
| "lighthouse": "./lighthouse-cli/index.js", | |||
| "chrome-debug": "./chrome-launcher/manual-chrome-launcher.js" | |||
| "chrome-debug": "./lighthouse-core/scripts/manual-chrome-launcher.js" | |||
There was a problem hiding this comment.
one option:
we remove this from the lh package and setup the bin over in chrome-launcher.
There was a problem hiding this comment.
Since we have yarn chrome now I'm fine removing chrome-debug, but I also don't install lighthouse globally anyways. It probably makes sense to not install with lighthouse? cc @patrickhulce
There was a problem hiding this comment.
I'm fine either way, I don't use chrome-debug these days
There was a problem hiding this comment.
after discussion, chrome-debug is still useful for testing a site requiring authentication with a global lighthouse install, so leaving for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4333, the long awaited followup to #3410 :)
With 3.0 coming up, we can get rid of any remaining chrome-launcher stubs (forwarded to the
chrome-launcherdep) previously maintained to be compatible with various docs and tutorials we put out in the past.manual-chrome-launcher.js(used bychrome-debugandyarn chrome) is moved toscripts/.