Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(lhr): s/audits/auditRefs, s/category.name/category.title/ #5157

Merged
merged 4 commits into from
May 9, 2018

Conversation

patrickhulce
Copy link
Collaborator

ref #4333 #5008

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with updates to indirect interface categoryMember names

typings/lhr.d.ts Outdated
/** A more detailed description of the category and its importance. */
description?: string;
/** A description for the manual audits in the category. */
manualDescription?: string;
/** The overall score of the category, the weighted average of all its audits. */
score: number|null;
/** An array of references to all the audit members of this category. */
audits: CategoryMember[];
auditRefs: CategoryMember[];
}

export interface CategoryMember {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AuditRef

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -103,7 +103,7 @@ declare global {
// TODO: For now, these are unchanged from JSON and Result versions. Need to harmonize.
export interface CategoryMember extends CategoryMemberJson {}
export interface Category extends CategoryJson {
audits: CategoryMember[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auditRef/auditRefJson up here too

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@paulirish paulirish added the 3.0 label May 9, 2018
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@paulirish paulirish merged commit 83cb1f7 into master May 9, 2018
@paulirish paulirish deleted the category_name_title branch May 9, 2018 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants