misc: drop support of Node 6 #4703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulirish do we have a policy on new code style? Write everything with async/await from now on? what to do with old gatherers/audits/core, ... |
I think what @brendankenny spelled out here is perfect: #3742 (comment) "A mostly organic transition to async/await would probably be best". 👍 👍 We'll refactor old code as we have reason to work on the files. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving to Node 8 as lowest supported version.
This is a breaking change, and we've already branched the
2.xbranch, as master is now our 3.0. ref #4333(Breaking ecc3d06 out of #4640 for clarity)
fixes #3742