extension: Pass flags from options in runLighthouseForConnection #4936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh are you trying to roll off of master @jianzhoufeng? there have been quite a few breaking changes which is why we've been trying to keep the branch2.x compatible, thanks for the PR though! this seems good either way |
patrickhulce
approved these changes
Apr 6, 2018
|
@patrickhulce |
|
Yes there are few more coming (some in #4333) along with quite a few output structure changes, there are discussion docs for, sorry we didn't keep you updated! the comms have been scattered in different channels |
|
I see. Next time I will keep this in mind. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@patrickhulce
We pass flags like disableDeviceEmulation from lightrider in options.flags, which used to work. It is broken now due to "unify config and CLI settings".
PTAL.
Thanks!