tests: run ToT and stable Chrome for smoke tests in github workflow #10989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jun 18, 2020
.github/workflows/ci.yml
Outdated
|
|
||
| # Chrome Stable is already installed by default. | ||
| - name: Install Chrome ToT | ||
| run: bash lighthouse-core/scripts/download-chrome.sh |
There was a problem hiding this comment.
AFAIK there's no caching w/ this approach. I don't think we want to cache ToT installation, right?
There was a problem hiding this comment.
I could see us caching within the same day or something, but I agree we don't want to cache for very long. either way followup seems fine.
patrickhulce
approved these changes
Jun 18, 2020
.github/workflows/ci.yml
Outdated
|
|
||
| # Chrome Stable is already installed by default. | ||
| - name: Install Chrome ToT | ||
| run: bash lighthouse-core/scripts/download-chrome.sh |
There was a problem hiding this comment.
I could see us caching within the same day or something, but I agree we don't want to cache for very long. either way followup seems fine.
connorjclark
changed the title
Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
connorjclark
changed the title
|
OK let's invalidate all these other PRs now :) |
gMakunde
pushed a commit
to gMakunde/lighthouse
that referenced
this pull request
Jul 6, 2020
gMakunde
pushed a commit
to gMakunde/lighthouse
that referenced
this pull request
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only appveyor runs ToT Chrome. Better to do both ToT and stable in GitHub CI.
#10988 will be necessary to avoid ~30m long builds.