-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: run ToT and stable Chrome for smoke tests in github workflow #10989
Merged
Merged
Changes from 19 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
1c8f6ad
wip
connorjclark 14eb344
wip
connorjclark c8b5c65
wip
connorjclark 698e5eb
wip
connorjclark 6f252f2
wip
connorjclark 5b2ee6b
wip
connorjclark 7d16195
wip
connorjclark 3a1f202
wip
connorjclark 795a199
wip
connorjclark 1510a7f
wip
connorjclark 9224b9b
wip
connorjclark 1689e8b
wip
connorjclark 1518a82
wip
connorjclark b8d373e
wip
connorjclark 7344a2c
wip
connorjclark 6842de6
wip
connorjclark 483a18b
wip
connorjclark 8970f99
wip
connorjclark f857ba8
wip
connorjclark 568792c
wip
connorjclark 275d763
wip
connorjclark 93acb82
Update .github/workflows/ci.yml
connorjclark 382c65c
wip
connorjclark b94b16a
wip
connorjclark 0b84e21
wip
connorjclark 38c5bb4
wip
connorjclark File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
#!/usr/bin/env bash | ||
|
||
## | ||
# @license Copyright 2017 The Lighthouse Authors. All Rights Reserved. | ||
# Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
# Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. | ||
## | ||
|
||
wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - | ||
sh -c 'echo "deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list' | ||
sudo apt-get update | ||
sudo apt-get install -y google-chrome-canary --no-install-recommends # Not a thing lol. | ||
sudo apt-get clean |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK there's no caching w/ this approach. I don't think we want to cache ToT installation, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could see us caching within the same day or something, but I agree we don't want to cache for very long. either way followup seems fine.