deps(lodash): use individual lodash modules to reduce bundle size #13914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this against my #13885 and it looks great. even saves an extra 4k! 👍 |
connorjclark
changed the title
paulirish
added a commit
that referenced
this pull request
Apr 26, 2022
brendankenny
approved these changes
Apr 26, 2022
connorjclark
added a commit
that referenced
this pull request
May 9, 2022
This was referenced Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13695 replaced our individual lodash packages with the whole lodash package, but we relied on treeshaking to keep the bundle small which didn't work because lodash's main module is a big IIFE.
Instead we can import individual modules. In hindsight, that's why lodash stopped publishing individual packages. Because you can just reach in and grab whatever you want.
devtools bundle size
before: 1705114
after: 1631433
~70KB less