Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(config): add expand and merge test #4747

Merged
merged 1 commit into from
Mar 14, 2018
Merged

tests(config): add expand and merge test #4747

merged 1 commit into from
Mar 14, 2018

Conversation

patrickhulce
Copy link
Collaborator

@paulirish
Copy link
Member

paulirish commented Mar 13, 2018 via email

@brendankenny
Copy link
Member

:)

brendankenny
brendankenny approved these changes Mar 14, 2018
View reviewed changes
Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I still think if some overwrite each other they all should, but better to test what we have now and find some sanity in #4333 :P

@brendankenny brendankenny merged commit a1c5433 into master Mar 14, 2018
@brendankenny brendankenny deleted the extended_options_config_test branch March 14, 2018 21:53
paulirish pushed a commit that referenced this pull request Mar 15, 2018
@patrickhulce @paulirish
tests(config): add merge-options test (#4747)
5f9210c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendankenny brendankenny brendankenny approved these changes

Assignees

@brendankenny brendankenny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrickhulce @paulirish @brendankenny @devtools-bot