Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new_audit(tap-targets): check that tap targets are big enough and don't overlap #5846

Merged
merged 107 commits into from
Jan 28, 2019
Merged

new_audit(tap-targets): check that tap targets are big enough and don't overlap #5846

merged 107 commits into from
Jan 28, 2019

Commits on Nov 15, 2018

  1. Support multi line outerHTML snippets

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    b0969df View commit details
    Browse the repository at this point in the history

  2. WIP

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    30669ce View commit details
    Browse the repository at this point in the history

  3. Check each target for overlap failure, even if it is already involved… 

    … in one
    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    db12c55 View commit details
    Browse the repository at this point in the history

  4. Fix table

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    f44c2fa View commit details
    Browse the repository at this point in the history

  5. makeClientRects helper function

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    cd6ec76 View commit details
    Browse the repository at this point in the history

  6. Clean up gatherer

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    9fc3125 View commit details
    Browse the repository at this point in the history

  7. Filter out tiny client rects

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    366f033 View commit details
    Browse the repository at this point in the history

  8. Clean up client rect functions

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    4823e53 View commit details
    Browse the repository at this point in the history

  9. Improve data available for debugging/tweaking finger size

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    b943ffd View commit details
    Browse the repository at this point in the history

  10. Tweak table titles

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    c0ad3b1 View commit details
    Browse the repository at this point in the history

  11. Rename BCR to client rects

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    34e0257 View commit details
    Browse the repository at this point in the history

  12. Move getNodePath to page functions

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    c70ec6e View commit details
    Browse the repository at this point in the history

  13. Add path to tap target node info

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    f80ef46 View commit details
    Browse the repository at this point in the history

  14. Add node selector to tap target node info

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    440c86e View commit details
    Browse the repository at this point in the history

  15. Show nothing instead of "n/a" when tap target isn't overlapped

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    7abf3cc View commit details
    Browse the repository at this point in the history

  16. Remove outdated comment

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    0354ec8 View commit details
    Browse the repository at this point in the history

  17. Fix TS error

    @mattzeunert
    mattzeunert committed Nov 15, 2018
    Configuration menu
    Copy the full SHA
    9da794c View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2018

  1. Only report targets that are overlapped

    @mattzeunert
    mattzeunert committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    3593623 View commit details
    Browse the repository at this point in the history

  2. Rename targetA and targetB

    @mattzeunert
    mattzeunert committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    a5c4e2f View commit details
    Browse the repository at this point in the history

  3. Tweak audit description

    @mattzeunert
    mattzeunert committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    e5fb2c2 View commit details
    Browse the repository at this point in the history

  4. Add more data for debugging

    @mattzeunert
    mattzeunert committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    b64a67d View commit details
    Browse the repository at this point in the history

  5. Move type def

    @mattzeunert
    mattzeunert committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    6256103 View commit details
    Browse the repository at this point in the history

  6. Fix linting

    @mattzeunert
    mattzeunert committed Nov 18, 2018
    Configuration menu
    Copy the full SHA
    4048f8a View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2018

  1. Clean up audit code

    @mattzeunert
    mattzeunert committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    52d9b4b View commit details
    Browse the repository at this point in the history

  2. Update snaphots

    @mattzeunert
    mattzeunert committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    ba1490e View commit details
    Browse the repository at this point in the history

  3. Tweak comment

    @mattzeunert
    mattzeunert committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    d38f6da View commit details
    Browse the repository at this point in the history

  4. Fix accessibility smoke test

    @mattzeunert
    mattzeunert committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    8bb5460 View commit details
    Browse the repository at this point in the history

  5. Ignore missing artifacts error

    @mattzeunert
    mattzeunert committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    1e45c4c View commit details
    Browse the repository at this point in the history

  6. Don't merge client rects if center of merged rect is outside original… 

    … rects
    @mattzeunert
    mattzeunert committed Nov 19, 2018
    Configuration menu
    Copy the full SHA
    409b5be View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2018

  1. Fix gatherer

    @mattzeunert
    mattzeunert committed Nov 21, 2018
    Configuration menu
    Copy the full SHA
    c705dfd View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2018

  1. Change display value to focus less on number of issues

    @mattzeunert
    mattzeunert committed Nov 25, 2018
    Configuration menu
    Copy the full SHA
    7e183d9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into HEAD

    @mattzeunert
    mattzeunert committed Nov 25, 2018
    Configuration menu
    Copy the full SHA
    2fa0ef4 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2018

  1. Move rect helpers to client rect functions

    Matt Zeunert authored and Matt Zeunert committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    acb63f9 View commit details
    Browse the repository at this point in the history

  2. Add more comments to audit code

    Matt Zeunert authored and Matt Zeunert committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    3f74c94 View commit details
    Browse the repository at this point in the history

  3. Add test case for fully contained tap target

    Matt Zeunert authored and Matt Zeunert committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    1183b38 View commit details
    Browse the repository at this point in the history

  4. Add tap targets smoke test

    Matt Zeunert authored and Matt Zeunert committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    29fb07a View commit details
    Browse the repository at this point in the history

  5. Tidy up audit logic

    Matt Zeunert authored and Matt Zeunert committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    0f76dbb View commit details
    Browse the repository at this point in the history

  6. Explain convert DOMRect to plain object

    Matt Zeunert authored and Matt Zeunert committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    7bb75b6 View commit details
    Browse the repository at this point in the history

  7. Use getElementsInDocument

    Matt Zeunert authored and Matt Zeunert committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    45cc9ea View commit details
    Browse the repository at this point in the history

  8. Fix code cov error

    Matt Zeunert authored and Matt Zeunert committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    9e9af23 View commit details
    Browse the repository at this point in the history

  9. Add extra if branch comments

    Matt Zeunert authored and Matt Zeunert committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    19a918f View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2018

  1. Don't mark invisible but displayed elements as inVisible

    Matt Zeunert authored and Matt Zeunert committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    e4c7791 View commit details
    Browse the repository at this point in the history

  2. Rename checkClientRectsInsideParents param

    Matt Zeunert authored and Matt Zeunert committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    c3b1e2c View commit details
    Browse the repository at this point in the history

  3. Fix spelling

    @mattzeunert
    mattzeunert committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    50d98ed View commit details
    Browse the repository at this point in the history

  4. New scoring logic

    @mattzeunert
    mattzeunert committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    a8f039d View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2018

  1. fixup Don't mark invisible but displayed elements as inVisible Matt Z… 

    …eunert committed
    @mattzeunert
    mattzeunert committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    d78bc27 View commit details
    Browse the repository at this point in the history

  2. WIP fix handling of partially hidden tap targets

    @mattzeunert
    mattzeunert committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    c9d8f2e View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into HEAD

    @mattzeunert
    mattzeunert committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    0e80231 View commit details
    Browse the repository at this point in the history

  4. Fix audit tap target test

    @mattzeunert
    mattzeunert committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    44ad070 View commit details
    Browse the repository at this point in the history

  5. wip

    @mattzeunert
    mattzeunert committed Dec 7, 2018
    Configuration menu
    Copy the full SHA
    df7615d View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2018

  1. core(minification): properly handle regex character classes (GoogleCh… 

    …rome#6745)
    @patrickhulce @mattzeunert
    patrickhulce authored and mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    302c04e View commit details
    Browse the repository at this point in the history

  2. core(tap-targets): helper functions for working with ClientRects (Goo… 

    …gleChrome#6703)
    @mattzeunert
    mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    a7e8ffb View commit details
    Browse the repository at this point in the history

  3. report: larger margins for audit group summaries (GoogleChrome#6688)

    @brendankenny @mattzeunert
    brendankenny authored and mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    e873dbb View commit details
    Browse the repository at this point in the history

  4. core(service-worker): check that start_url is within SW's scope (Goog… 

    …leChrome#6678)
    @brendankenny @mattzeunert
    brendankenny authored and mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    7201f6b View commit details
    Browse the repository at this point in the history

  5. Fix after merge

    @mattzeunert
    mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    974e277 View commit details
    Browse the repository at this point in the history

  6. Ignore position absolute tap targets

    @mattzeunert
    mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    7c59b8c View commit details
    Browse the repository at this point in the history

  7. remove old files

    @mattzeunert
    mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    3b49651 View commit details
    Browse the repository at this point in the history

  8. Tweaks

    @mattzeunert
    mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    61e0a81 View commit details
    Browse the repository at this point in the history

  9. Tweak

    @mattzeunert
    mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    7121672 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into HEAD

    @mattzeunert
    mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    1f54523 View commit details
    Browse the repository at this point in the history

  11. Tidy up code

    @mattzeunert
    mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    05fa8b9 View commit details
    Browse the repository at this point in the history

  12. Add smoke test for invisible position absolute tap target

    @mattzeunert
    mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    2f09fd4 View commit details
    Browse the repository at this point in the history

  13. Remove memoize isVisibleNode since at least in its current form it do… 

    …esn't speed things up
    @mattzeunert
    mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    e6c51a8 View commit details
    Browse the repository at this point in the history

  14. Add comment

    @mattzeunert
    mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    64d184b View commit details
    Browse the repository at this point in the history

  15. singular

    @mattzeunert
    mattzeunert committed Dec 8, 2018
    Configuration menu
    Copy the full SHA
    e9de137 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2018

  1. Ignore tap targets that are nested inside a parent

    @mattzeunert
    mattzeunert committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    5dd5c40 View commit details
    Browse the repository at this point in the history

  2. Smoke test for overlapping tap targets with same href

    @mattzeunert
    mattzeunert committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    e6fbf8a View commit details
    Browse the repository at this point in the history

  3. Merge rects more generously

    @mattzeunert
    mattzeunert committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    4701c24 View commit details
    Browse the repository at this point in the history

  4. Fix skipping tap targets when going through ancestors, stop just befo… 

    …re body
    @mattzeunert
    mattzeunert committed Dec 12, 2018
    Configuration menu
    Copy the full SHA
    465fcc0 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2019

  1. Add smoke test for position absolute tap target fully contained by an… 

    …other one
    @mattzeunert
    mattzeunert committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    9933b30 View commit details
    Browse the repository at this point in the history

  2. Move allRectsContainedWithinEachOther out of loop

    @mattzeunert
    mattzeunert committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    b3228f1 View commit details
    Browse the repository at this point in the history

  3. Tweaks/renaming

    @mattzeunert
    mattzeunert committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    d9a5a57 View commit details
    Browse the repository at this point in the history

  4. Don't report symmetric failures twice

    @mattzeunert
    mattzeunert committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    d5b1cf9 View commit details
    Browse the repository at this point in the history

  5. Fix type

    @mattzeunert
    mattzeunert committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    9e1a0ef View commit details
    Browse the repository at this point in the history

  6. Tweak

    @mattzeunert
    mattzeunert committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    1459fb9 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into HEAD

    @mattzeunert
    mattzeunert committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    767e13e View commit details
    Browse the repository at this point in the history

  8. Update sample json

    @mattzeunert
    mattzeunert committed Jan 4, 2019
    Configuration menu
    Copy the full SHA
    13e5193 View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2019

  1. Feedback Fixes

    @mattzeunert
    mattzeunert committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    cd6ee28 View commit details
    Browse the repository at this point in the history

  2. Truncate outerHTML at 300 chars

    @mattzeunert
    mattzeunert committed Jan 6, 2019
    Configuration menu
    Copy the full SHA
    8188e6b View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2019

  1. Rename uniqueOverlapFailures to overlapFailuresForDisplay

    @mattzeunert
    mattzeunert committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    21c154e View commit details
    Browse the repository at this point in the history

  2. Change TapTargetTableItem to interface

    @mattzeunert
    mattzeunert committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    ccf0418 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2019

  1. Move comment

    @mattzeunert
    mattzeunert committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    a1e134f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into HEAD

    @mattzeunert
    mattzeunert committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    d3595e2 View commit details
    Browse the repository at this point in the history

  3. Change Viewport artifact dependency to MetaElements

    @mattzeunert
    mattzeunert committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    a33f181 View commit details
    Browse the repository at this point in the history

  4. Node -> Element

    @mattzeunert
    mattzeunert committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    1dd2d3d View commit details
    Browse the repository at this point in the history

  5. Explain why we only check content in text nodes for elementIsInTextBlock

    @mattzeunert
    mattzeunert committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    928cf76 View commit details
    Browse the repository at this point in the history

  6. Type fix

    @mattzeunert
    mattzeunert committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    2c95d32 View commit details
    Browse the repository at this point in the history

  7. Move ClientRectOverlapFailure/TapTargetOverlapFailure out of audit.d.ts

    @mattzeunert
    mattzeunert committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    7793a58 View commit details
    Browse the repository at this point in the history

  8. Don't crash if Element.prototype.matches is overridden

    @mattzeunert
    mattzeunert committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    c2c2896 View commit details
    Browse the repository at this point in the history

  9. Tweaks

    @mattzeunert
    mattzeunert committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    0138978 View commit details
    Browse the repository at this point in the history

  10. Add full audit error to smoke test expectations

    @mattzeunert
    mattzeunert committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    1fc2c8f View commit details
    Browse the repository at this point in the history

  11. Fix line length

    @mattzeunert
    mattzeunert committed Jan 19, 2019
    Configuration menu
    Copy the full SHA
    900dd3f View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Use useIsolation to handle matches being overwritten

    @mattzeunert
    mattzeunert committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    9f58755 View commit details
    Browse the repository at this point in the history

  2. Move hasTextNodeSiblingsFormingTextBlock outside function block

    @mattzeunert
    mattzeunert committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    5bfd792 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary if statement

    @mattzeunert
    mattzeunert committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    d320c4f View commit details
    Browse the repository at this point in the history

  4. Remove ThemeColor/Viewport that was restored during merge

    @mattzeunert
    mattzeunert committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    a001852 View commit details
    Browse the repository at this point in the history

  5. Removed unused window var

    @mattzeunert
    mattzeunert committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    be53ec6 View commit details
    Browse the repository at this point in the history

  6. Add test case for overwritten matches function

    @mattzeunert
    mattzeunert committed Jan 23, 2019
    Configuration menu
    Copy the full SHA
    ba795c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. Make failed viewport audit message in tap targets/font size more spec… 

    …ific
    @mattzeunert
    mattzeunert committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    8fd667c View commit details
    Browse the repository at this point in the history

  2. Fix tests following previous change

    @mattzeunert
    mattzeunert committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    efec03b View commit details
    Browse the repository at this point in the history

  3. Fix line length for previous changes

    @mattzeunert
    mattzeunert committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    f58fe21 View commit details
    Browse the repository at this point in the history

  4. Tweaks

    @mattzeunert
    mattzeunert committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    4ae7575 View commit details
    Browse the repository at this point in the history

  5. Shorten getTableItems code

    @mattzeunert
    mattzeunert committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    de60ebb View commit details
    Browse the repository at this point in the history

  6. Move TapTargetTableItem type

    @mattzeunert
    mattzeunert committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    7d497ae View commit details
    Browse the repository at this point in the history

  7. Add test case for no viewport meta tag

    @mattzeunert
    mattzeunert committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    1597590 View commit details
    Browse the repository at this point in the history

  8. Test case for only one tap target in a pair failing

    @mattzeunert
    mattzeunert committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    2a33179 View commit details
    Browse the repository at this point in the history

  9. Rename test options to make more sense

    @mattzeunert
    mattzeunert committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    729eaaf View commit details
    Browse the repository at this point in the history