bluetooth: Add acceptAllDevices #458
Conversation
| log('Requesting Bluetooth Device...'); | ||
| navigator.bluetooth.requestDevice({filters: filters}) | ||
| log('with ' + JSON.stringify(options)); | ||
| navigator.bluetooth.requestDevice(options) |
There was a problem hiding this comment.
Note that you are not allowed to use acceptAllDevices with filters so you might need some logic for that.
There was a problem hiding this comment.
Thanks! I've fixed that in 4ebbcd1
| return navigator.bluetooth.requestDevice( | ||
| {filters: anyNamedDevice(), optionalServices: ['battery_service']}) | ||
| return navigator.bluetooth.requestDevice({ | ||
| acceptAllDevices: true, optionalServices: ['battery_service']}) |
There was a problem hiding this comment.
It makes me sad that we are using acceptAllDevices so liberally. I recognize the desire to make our samples super easy to use but every developer that copies this code will end up using it which will result in a bunch of unrelated devices being shown in the chooser and energy being wasted because we have no filters.
There was a problem hiding this comment.
Would 9533907 be enough?
| @@ -3,9 +3,9 @@ var bluetoothDevice; | |||
| async function onButtonClick() { | |||
| bluetoothDevice = null; | |||
| try { | |||
| log('Requesting any Bluetooth Device...'); | |||
| log('Requesting any Bluetooth Device... (NOT RECOMMENDED - USE FILTERS)'); | |||
There was a problem hiding this comment.
I don't think it's that clear what exactly is not recommended?
navigator.bluetooth.requestDevice({
acceptAllDevices: true /* NOT RECOMMENDED - USE FILTERS */});Also fwiw: 10% of the devices requests have been using anyNamedDevice().
There was a problem hiding this comment.
Or maybe:
navigator.bluetooth.requestDevice({
// filters [{...}] <- Prefer to use filters to save energy and show only relevant devices.
acceptAllDevices: true
});
beaufortfrancois
force-pushed
the
acceptAllDevices
branch
from
9533907 to
5f0a821
Compare
|
lgtm |
|
I'll wait for M56 to land in Stable channel before merging this CL then. |
* bluetooth: Add acceptAllDevices * Don't use both acceptAllDevices and filters * Add warning about acceptAllDevices * Converted missing link-loss sample * Remove autofocus for prefilled fields
You can give a try to this updated samples at https://beaufortfrancois.github.io/samples/web-bluetooth.
https://beaufortfrancois.github.io/samples/web-bluetooth/device-info.html and any sample previously using
anyNamedDevicehave been updated to useacceptAllDevices.R: @g-ortuno @jeffposnick