Use requestDevice({ acceptAllDevices:true }) in rename tool. #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hack 'anyDeviceFilter' is no longer necessary now that request device supports acceptAllDevices.
|
I'll merge this once M56 hits stable channel along
GoogleChrome/samples#458
WDYT?
…On Thu, Jan 12, 2017 at 8:49 PM Vincent Scheib ***@***.***> wrote:
@scheib <https://github.com/scheib> requested your review on:
WebBluetoothCG/demos#61 <#61>
Use requestDevice({ acceptAllDevices:true }) in rename tool..
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#61 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAmubhee0MfqUVXvIk8gZzgkHo1JIq-Rks5rRoPlgaJpZM4LiKRE>
.
|
|
SG
On Thu, Jan 12, 2017 at 11:53 AM, François Beaufort <
notifications@github.com> wrote:
… I'll merge this once M56 hits stable channel along
GoogleChrome/samples#458
WDYT?
On Thu, Jan 12, 2017 at 8:49 PM Vincent Scheib ***@***.***>
wrote:
> @scheib <https://github.com/scheib> requested your review on:
> WebBluetoothCG/demos#61 <#61
>
> Use requestDevice({ acceptAllDevices:true }) in rename tool..
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#61 (comment)>, or
mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/
AAmubhee0MfqUVXvIk8gZzgkHo1JIq-Rks5rRoPlgaJpZM4LiKRE>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#61 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXnm2oC3MYr_Q7dg5n5Fgxys0kSwzIDks5rRoTRgaJpZM4LiKRE>
.
|
| @@ -161,7 +153,7 @@ | |||
| throw "No Web Bluetooth support."; | |||
|
|
|||
| return navigator.bluetooth.requestDevice({ | |||
| filters: anyDeviceFilter(), | |||
| acceptAllDevices:true, | |||
There was a problem hiding this comment.
Do you mind adding a comment like https://github.com/GoogleChrome/samples/pull/458/files#diff-ef7cbca5c52cb429b47a308074bf06bcR7?
+ // filters: [...] <- Prefer filters to save energy & show relevant devices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hack 'anyDeviceFilter' is no longer necessary now that
request device supports acceptAllDevices.