Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

update metric thresholds for Lighthouse 8 #5544

Merged
merged 1 commit into from
Jun 8, 2021
Merged

update metric thresholds for Lighthouse 8 #5544

merged 1 commit into from
Jun 8, 2021

Conversation

brendankenny
Copy link
Member

Lighthouse 8 was just released and brought new score thresholds for total-blocking-time and first-contentful-paint and a re-weighting of the overall performance score.

I also noticed that the speed-index thresholds were incorrect and the screenshots were out of date (showing old metrics), so I updated those and a few random obsolete links.

This isn't the full revamp some of these articles need, but that can wait for the migration to d.c.c (or whatever we decide to do there).

@chrome-devrel-review-bot
Copy link
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

src/site/content/en/lighthouse-performance/first-contentful-paint/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 92

src/site/content/en/lighthouse-performance/interactive/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 118

src/site/content/en/lighthouse-performance/lighthouse-largest-contentful-paint/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 70

src/site/content/en/lighthouse-performance/lighthouse-total-blocking-time/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 90

src/site/content/en/lighthouse-performance/performance-scoring/index.md

  • Please break lines at 100 characters maximum. Long lines can be difficult to work with in GitHub's pull request UI. The following tools can help speed up the process: Rewrap (VS Code), Docs To X (Google Docs; only available for Googlers). Affected lines: 16, 20, 29, 39, 44, 51, 54, 140, 150, 154, 163, 173, 176, 178, 182
  • Please put a blank line before and after each section heading. Some Markdown parsers don't detect the text as a section heading unless there is blank space before and after it. Affected lines: 175
  • Please change your usage of the following words:
    • Do not use master. Affected lines: 29

src/site/content/en/lighthouse-performance/speed-index/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 85

@google-cla google-cla bot added the cla: yes Contributor has signed the CLA label Jun 4, 2021
@github-actions
Copy link

github-actions bot commented Jun 4, 2021

Visit the preview URL for this PR (updated for commit b323658):

https://web-dev-production-1--pr-5544-ltdoa3cp.web.app

(expires Fri, 11 Jun 2021 21:51:41 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@netlify
Copy link

netlify bot commented Jun 4, 2021

✔️ Deploy Preview for web-dev-staging ready!

🔨 Explore the source changes: b323658

🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/60ba9f71f02188000854601c

😎 Browse the preview: https://deploy-preview-5544--web-dev-staging.netlify.app

@brendankenny
Copy link
Member Author

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

all of these were pre-existing and not touched by this PR

  • Most of them are due to lighthouse unfortunately not migrating to main yet, so there's not much that can be done there yet
  • The line-length issues aren't on any of the changed lines and would add a lot to the PR diff, but I could take a pass at that if it's important

<td>Green (fast)</td>
<td>75–100</td>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these have been removed on the newer metric pages (e.g. https://web.dev/lighthouse-total-blocking-time/#how-lighthouse-determines-your-tbt-score) and Lighthouse doesn't expose the per-metric score directly (just in the raw JSON response), so it seemed good to remove them (otherwise they need to be updated to 90-100)

@@ -29,17 +29,14 @@ to generate the Speed Index score.

{% Aside %}
Speedline is based on the same principles as the
[original speed index introduced by WebpageTest.org](https://github.com/WPO-Foundation/webpagetest-docs/blob/master/user/Metrics/SpeedIndex.md),
but it computes the visual progression between frames using the
[structural similarity (SSIM) index](https://en.wikipedia.org/wiki/Structural_similarity)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lighthouse moved off SSIM in GoogleChrome/lighthouse#4980

@philipwalton philipwalton merged commit 9307853 into main Jun 8, 2021
@philipwalton philipwalton deleted the lh8-update branch June 8, 2021 19:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Contributor has signed the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants