-
Notifications
You must be signed in to change notification settings - Fork 1.6k
update metric thresholds for Lighthouse 8 #5544
Conversation
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated. Requested changesIf there are any common problems with the content files you created or modified, they will be listed here.
|
Visit the preview URL for this PR (updated for commit b323658): https://web-dev-production-1--pr-5544-ltdoa3cp.web.app (expires Fri, 11 Jun 2021 21:51:41 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
✔️ Deploy Preview for web-dev-staging ready! 🔨 Explore the source changes: b323658 🔍 Inspect the deploy log: https://app.netlify.com/sites/web-dev-staging/deploys/60ba9f71f02188000854601c 😎 Browse the preview: https://deploy-preview-5544--web-dev-staging.netlify.app |
all of these were pre-existing and not touched by this PR
|
<td>Green (fast)</td> | ||
<td>75–100</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these have been removed on the newer metric pages (e.g. https://web.dev/lighthouse-total-blocking-time/#how-lighthouse-determines-your-tbt-score) and Lighthouse doesn't expose the per-metric score directly (just in the raw JSON response), so it seemed good to remove them (otherwise they need to be updated to 90-100)
@@ -29,17 +29,14 @@ to generate the Speed Index score. | |||
|
|||
{% Aside %} | |||
Speedline is based on the same principles as the | |||
[original speed index introduced by WebpageTest.org](https://github.com/WPO-Foundation/webpagetest-docs/blob/master/user/Metrics/SpeedIndex.md), | |||
but it computes the visual progression between frames using the | |||
[structural similarity (SSIM) index](https://en.wikipedia.org/wiki/Structural_similarity) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lighthouse moved off SSIM in GoogleChrome/lighthouse#4980
Lighthouse 8 was just released and brought new score thresholds for
total-blocking-time
andfirst-contentful-paint
and a re-weighting of the overall performance score.I also noticed that the
speed-index
thresholds were incorrect and the screenshots were out of date (showing old metrics), so I updated those and a few random obsolete links.This isn't the full revamp some of these articles need, but that can wait for the migration to d.c.c (or whatever we decide to do there).