Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-global-removal #1080

Merged
merged 1 commit into from
Nov 30, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/workbox-background-sync/models/StorableRequest.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ export default class StorableRequest {
*
* @param {Request} request
* @return {Promise<StorableRequest>}
*
* @private
*/
static async fromRequest(request) {
const requestInit = {headers: {}};
Expand Down Expand Up @@ -79,6 +81,8 @@ export default class StorableRequest {
* See: https://fetch.spec.whatwg.org/#requestinit
* @param {number} param1.timestamp The time the request was created,
* defaulting to the current time if not specified.
*
* @private
*/
constructor({url, requestInit, timestamp = Date.now()}) {
this.url = url;
Expand All @@ -92,6 +96,8 @@ export default class StorableRequest {
* Gets the private _timestamp property.
*
* @return {number}
*
* @private
*/
get timestamp() {
return this._timestamp;
Expand All @@ -101,6 +107,8 @@ export default class StorableRequest {
* Coverts this instance to a plain Object.
*
* @return {Object}
*
* @private
*/
toObject() {
return {
Expand All @@ -114,6 +122,8 @@ export default class StorableRequest {
* Converts this instance to a Request.
*
* @return {Request}
*
* @private
*/
toRequest() {
return new Request(this.url, this.requestInit);
Expand Down
2 changes: 2 additions & 0 deletions packages/workbox-webpack-plugin/src/lib/utils/read-file.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@
* `readFile` is configured to use `compiler.inputFileSystem._readFile` during
* the run phase of the webpack compilation lifecycle by passing the function
* to the `setReadFile` function.
*
* @private
*/
let readFileFn;

Expand Down