Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc-global-removal #1080

Merged
merged 1 commit into from
Nov 30, 2017
Merged

doc-global-removal #1080

merged 1 commit into from
Nov 30, 2017

Conversation

gauntface
Copy link

Globals were being documented when they shouldn't - will add a link check for this.

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.17 KB 3.16 KB -0% 1.33 KB
packages/workbox-cli/build/app.js 4.49 KB 3.93 KB -13% 1.48 KB 🎉
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 1.93 KB 1.97 KB +2% 969 B

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.17 KB 3.16 KB -0% 1.33 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.07 KB 1.07 KB 0% 567 B
packages/workbox-build/build/index.js 16.62 KB 16.62 KB 0% 5.07 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.15 KB 3.15 KB 0% 1.16 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 610 B 610 B 0% 344 B
packages/workbox-cli/build/app.js 4.49 KB 3.93 KB -13% 1.48 KB 🎉
packages/workbox-cli/build/bin.js 2.53 KB 2.53 KB 0% 1.07 KB
packages/workbox-core/build/workbox-core.prod.js 6.67 KB 6.67 KB 0% 2.61 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 1.93 KB 1.97 KB +2% 969 B
packages/workbox-precaching/build/workbox-precaching.prod.js 4.75 KB 4.75 KB 0% 1.84 KB
packages/workbox-routing/build/workbox-routing.prod.js 2.74 KB 2.74 KB 0% 1.23 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 3.54 KB 3.54 KB 0% 1.13 KB
packages/workbox-sw/build/workbox-sw.js 1.35 KB 1.35 KB 0% 737 B
packages/workbox-webpack-plugin/build/index.js 7.46 KB 7.46 KB 0% 2.49 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 152% of our max size budget.

Total Size: 22.26KB
Percentage of Size Used: 152%

Gzipped: 8.84KB

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7d4bc51 on doc-global-removal into ** on v3**.

@gauntface gauntface mentioned this pull request Nov 30, 2017
@gauntface gauntface requested a review from addyosmani November 30, 2017 00:32
Copy link
Member

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyosmani addyosmani merged commit 5a148a7 into v3 Nov 30, 2017
@addyosmani addyosmani deleted the doc-global-removal branch November 30, 2017 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants