Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding JSDocs checks #1081

Merged
merged 13 commits into from
Nov 30, 2017
Merged

Adding JSDocs checks #1081

merged 13 commits into from
Nov 30, 2017

Conversation

gauntface
Copy link

This will fail the test until #1080 is merged, then we can re-run and check the tests pass.

Checks for:

  • No globals
  • No module.exports (Something that is showing up in the WebFundamentals build for v3.0.0-alpha.1) at the moment.

Copy link
Member

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling cb90475 on jsdocs-checks into ** on v3**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d55f188 on jsdocs-checks into ** on v3**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 1e4b46c on jsdocs-checks into ** on v3**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 11cb2e3 on jsdocs-checks into ** on v3**.

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

No file sizes have changed.

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.17 KB 3.17 KB 0% 1.34 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.07 KB 1.07 KB 0% 567 B
packages/workbox-build/build/index.js 16.62 KB 16.62 KB 0% 5.07 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.15 KB 3.15 KB 0% 1.16 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 610 B 610 B 0% 344 B
packages/workbox-cli/build/app.js 4.49 KB 4.49 KB 0% 1.61 KB
packages/workbox-cli/build/bin.js 2.53 KB 2.53 KB 0% 1.07 KB
packages/workbox-core/build/workbox-core.prod.js 6.67 KB 6.67 KB 0% 2.61 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 1.93 KB 1.93 KB 0% 961 B
packages/workbox-precaching/build/workbox-precaching.prod.js 4.75 KB 4.75 KB 0% 1.84 KB
packages/workbox-routing/build/workbox-routing.prod.js 2.74 KB 2.74 KB 0% 1.23 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 3.54 KB 3.54 KB 0% 1.13 KB
packages/workbox-sw/build/workbox-sw.js 1.35 KB 1.35 KB 0% 737 B
packages/workbox-webpack-plugin/build/index.js 7.46 KB 7.46 KB 0% 2.49 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 152% of our max size budget.

Total Size: 22.26KB
Percentage of Size Used: 152%

Gzipped: 8.84KB

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 78a7f0c on jsdocs-checks into ** on v3**.

@gauntface gauntface merged commit 2445dea into v3 Nov 30, 2017
@gauntface gauntface deleted the jsdocs-checks branch November 30, 2017 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants