Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rollup-plugin): replace package rollup-plugin-terser by @rollup/plugin-terser #3170

Merged
merged 2 commits into from
Apr 16, 2024
Merged

fix(rollup-plugin): replace package rollup-plugin-terser by @rollup/plugin-terser #3170

merged 2 commits into from
Apr 16, 2024

Conversation

ansidev
Copy link
Contributor

@ansidev ansidev commented Jan 30, 2023 •
edited
Loading

Prior to creating a pull request, please follow all the steps in the contributing guide.

Fixes #3136, #3144

Description of what's changed/fixed.

  • Replaces the package rollup-plugin-terser by @rollup/plugin-terser since rollup-plugin-terser is deprecated.

@ansidev ansidev force-pushed the deps/rollup/plugin-terser branch from 76a5e14 to 9265672 Compare January 30, 2023 20:16
Jppnp
Jppnp approved these changes Mar 11, 2023
View reviewed changes
Copy link

@Jppnp Jppnp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be done

@Artur-
Copy link

Artur- commented Jun 27, 2023

Could this be merged now that there is a workbox 7, @tropicadri ?

This was referenced Jun 27, 2023
Open
Closed
@ansidev ansidev force-pushed the deps/rollup/plugin-terser branch from 9265672 to 084eaf0 Compare June 28, 2023 06:32
@ansidev ansidev changed the base branch from v6 to v7 June 28, 2023 06:33
@ansidev
Copy link
Contributor Author

ansidev commented Jun 28, 2023

Rebased onto v7!

@drewbitt drewbitt mentioned this pull request Jul 27, 2023
Closed
@alangdm
Copy link

alangdm commented Aug 8, 2023

Any chance we could see this get merged?
I'm getting errors using tools that depend on this package that have already removed the deprecated terser

@ansidev
Copy link
Contributor Author

ansidev commented Aug 8, 2023

It seems that maintainers are laid-off 🙃

@thepassle
Copy link

This is also causing issues for consumers of rollup-plugin-workbox apparently, so indeed would be great to get this merged :)

@DamianGlowala
Copy link

@philipwalton, please? 🙏

@davidtranjs
Copy link

Please help to check this PR, it would help a lot 🥺

@pwbriggs
Copy link

Fixes #3136, #3144

Also fixes #3142, #3154, #3200, and #3228. @GoogleChrome @jeffposnick @philipwalton can someone please merge this PR?

t-montes
t-montes approved these changes Oct 22, 2023
View reviewed changes
Copy link

@t-montes t-montes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies the fix correctly:
This package has been deprecated and is no longer maintained. Please use @rollup/plugin-terser

@Ten-Taken
Copy link

Would love to see a fix as well. I think this is now causing issues with rollup's dynamic imports. I suspect an unpinned dependency in the older rollup repos.

@ansidev
Copy link
Contributor Author

ansidev commented Mar 20, 2024

I guess Google does not care about this project anymore, the latest commit is pushed 10 months ago.

@tropicadri tropicadri merged commit 70b1088 into GoogleChrome:v7 Apr 16, 2024
@ansidev ansidev deleted the deps/rollup/plugin-terser branch April 16, 2024 23:21
This was referenced Apr 17, 2024
Closed
Closed
@pwbriggs pwbriggs mentioned this pull request Apr 17, 2024
Closed
This was referenced Apr 24, 2024
Open
Open
@Jeremy250MG Jeremy250MG mentioned this pull request Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jppnp Jppnp Jppnp approved these changes

@smirnoffmv smirnoffmv smirnoffmv approved these changes

@kennarddh kennarddh kennarddh approved these changes

@t-montes t-montes t-montes approved these changes

@AFCMS AFCMS AFCMS approved these changes

@Lure5134 Lure5134 Lure5134 approved these changes

@DysektAI DysektAI DysektAI approved these changes

@tropicadri tropicadri tropicadri approved these changes

@rivajunior rivajunior rivajunior approved these changes

@Chevindu Chevindu Chevindu approved these changes

@hellohejinyu hellohejinyu hellohejinyu approved these changes

@TemaSM TemaSM TemaSM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecated rollup-plugin-terser@7.0.2